Operations

Operational Conventions

Code Review

Self Stamping and Merging

On our Gerrit, core members have permissions to +2 any arbitrary CL, because sometimes we should be able to get something in quickly, and talk about it afterwards. In almost every case, the author of a change should not +2 their own CL, however Lix members may use their best judgement so long as they talk about it with the team when they can. Some cases where skipping synchronous review is a good idea:

• Fixing a trivial typo
• Reverting commits that accidentally broke main
• Fixing typos in other peoples' CLs that you would have +2'd, then +2'ing the edited CL
• Maybe typo fixes in main, though those can probably wait to be reviewed

Just make sure to talk about what you do :)